Hi Sakari, On 8/16/19 10:15 AM, Sakari Ailus wrote: > Hi Hugues, > > On Wed, Aug 14, 2019 at 03:48:51PM +0200, Hugues Fruchet wrote: >> Add a trace of the set of supported fourcc/mbus_code which >> intersect between DCMI and source sub-device. >> >> Signed-off-by: Hugues Fruchet <[email protected]> >> --- >> drivers/media/platform/stm32/stm32-dcmi.c | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c >> b/drivers/media/platform/stm32/stm32-dcmi.c >> index b462f71..18acecf 100644 >> --- a/drivers/media/platform/stm32/stm32-dcmi.c >> +++ b/drivers/media/platform/stm32/stm32-dcmi.c >> @@ -1447,12 +1447,20 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi) >> /* Code supported, have we got this fourcc yet? */ >> for (j = 0; j < num_fmts; j++) >> if (sd_fmts[j]->fourcc == >> - dcmi_formats[i].fourcc) >> + dcmi_formats[i].fourcc) { >> /* Already available */ >> + dev_dbg(dcmi->dev, "Skipping >> fourcc/code: %4.4s/0x%x\n", >> + (char *)&sd_fmts[j]->fourcc, >> + mbus_code.code); >> break; >> - if (j == num_fmts) >> + } >> + if (j == num_fmts) { >> /* New */ >> sd_fmts[num_fmts++] = dcmi_formats + i; >> + dev_dbg(dcmi->dev, "Supported fourcc/code: >> %4.4s/0x%x\n", > > Over 80 characters per line. >
This an exception of the "80 chars" in order to be able to grep in kernel messages: https://www.kernel.org/doc/html/v4.10/process/coding-style.html "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." This exception is managed in checkpatch.pl (--strict). >> + (char *)&sd_fmts[num_fmts - 1]->fourcc, >> + sd_fmts[num_fmts - 1]->mbus_code); >> + } >> } >> mbus_code.index++; >> } > BR, Hugues.
