On Sun, Aug 18, 2019 at 03:07:18PM -0700, Joe Perches wrote: > Also the original patch deletes 2 case entries for > PTP_PIN_GETFUNC and PTP_PIN_SETFUNC and converts them to > PTP_PIN_GETFUNC2 and PTP_PIN_SETFUNC2 but still uses tests > for the deleted case label entries making part of the case > code block unreachable. > > That's at least a defect: > > - case PTP_PIN_GETFUNC: > + case PTP_PIN_GETFUNC2: > > and > > - case PTP_PIN_SETFUNC: > + case PTP_PIN_SETFUNC2:
Good catch. Felipe, please fix that! (Regarding Joe's memset suggestion, I'll leave that to your discretion.) Thanks, Richard
