On 8/21/19 6:41 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Reported-by: Hulk Robot <hul...@huawei.com>
> Signed-off-by: YueHaibing <yuehaib...@huawei.com>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c 
> b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index d3a0b61..2108e59 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3437,7 +3437,6 @@ static int bcmgenet_probe(struct platform_device *pdev)
>       struct bcmgenet_priv *priv;
>       struct net_device *dev;
>       const void *macaddr;
> -     struct resource *r;
>       unsigned int i;
>       int err = -EIO;
>       const char *phy_mode_str;
> @@ -3477,8 +3476,7 @@ static int bcmgenet_probe(struct platform_device *pdev)
>               macaddr = pd->mac_address;
>       }
>  
> -     r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -     priv->base = devm_ioremap_resource(&pdev->dev, r);
> +     priv->base = devm_platform_ioremap_resource(pdev, 0);
>       if (IS_ERR(priv->base)) {
>               err = PTR_ERR(priv->base);
>               goto err;
> 

Acked-by: Doug Berger <open...@gmail.com>

Reply via email to