Hi Alex, > -----Original Message----- > From: [email protected] <linux-kernel- > [email protected]> On Behalf Of Parav Pandit > Sent: Saturday, August 24, 2019 9:26 AM > To: Alex Williamson <[email protected]> > Cc: Jiri Pirko <[email protected]>; Jiri Pirko <[email protected]>; David S . > Miller <[email protected]>; Kirti Wankhede <[email protected]>; > Cornelia Huck <[email protected]>; [email protected]; linux- > [email protected]; cjia <[email protected]>; [email protected] > Subject: RE: [PATCH v2 0/2] Simplify mtty driver and mdev core > > I don't understand this logic. I'm simply asking that we have a way > > to test the collision behavior without changing the binary. The path > > we're driving towards seems to be making this easier and easier. If > > the vendor can request an alias of a specific length, then a sample > > driver with a module option to set the desired alias length to 1-char makes > it trivially easy to induce a collision. > Sure it is easy to test collision, but my point is - mdev core is not sha1 > test > module. > Hence adding functionality of variable alias length to test collision doesn't > make sense. > When the actual user arrives who needs small alias, we will be able to add > additional pieces very easily.
My initial thoughts to add parent_ops to have bool flag to generate alias or not. However, instead of bool, keeping it unsigned int to say, zero to skip alias and non-zero length to convey generate alias. This will serve both the purpose with trivial handling.
