On 26.08.19 16:02, Boris Brezillon wrote: > On Mon, 26 Aug 2019 13:38:48 +0000 > Schrempf Frieder <frieder.schre...@kontron.de> wrote: > >> On 26.08.19 14:40, Boris Brezillon wrote: >>> On Mon, 26 Aug 2019 12:08:58 +0000 >>> <tudor.amba...@microchip.com> wrote: >>> >>>> From: Tudor Ambarus <tudor.amba...@microchip.com> >>>> >>>> nor->params.setup() configures the SPI NOR memory. Useful for SPI NOR >>>> flashes that have peculiarities to the SPI NOR standard, e.g. >>>> different opcodes, specific address calculation, page size, etc. >>>> Right now the only user will be the S3AN chips, but other >>>> manufacturers can implement it if needed. >>>> >>>> Move spi_nor_setup() related code in order to avoid a forward >>>> declaration to spi_nor_default_setup(). >>>> >>>> Reviewed-by: Boris Brezillon <boris.brezil...@collabora.com> >>> >>> Nitpick: R-bs should normally be placed after your SoB. >> >> Just a question unrelated to the patch content: >> >> I learned to add R-b tags after my SoB when submitting MTD patches, but >> recently I submitted a patch to the serial subsystem and was told to put >> my SoB last. Is there an "official" rule for this? And if so where to >> find it? > > Should match the order of addition: if you picked an existing patch that > had already received R-b/A-b tags and applied it to your tree you > should add your SoB at the end. But if you are the author, your SoB > should come first. At least that's the rule I follow :-).
Ok, thanks for clarifying. I was the author of said patch and was adding an R-b just like in this case here, so the people in the serial subsystem seem to apply different rules ;)
