Em Sun, Aug 25, 2019 at 08:17:40PM +0200, Jiri Olsa escreveu: > hi, > as a preparation for sampling libperf interface, moving event > definitions into the library header. Moving just the kernel > non-AUX events now. > > In order to keep libperf simple, we switch 'u64/u32/u16/u8' > types used events to their generic '__u*' versions. > > Perf added 'u*' types mainly to ease up printing __u64 values > as stated in the linux/types.h comment: > > /* > * We define u64 as uint64_t for every architecture > * so that we can print it with "%"PRIx64 without getting warnings. > * > * typedef __u64 u64; > * typedef __s64 s64; > */ > > Adding and using new PRI_lu64 and PRI_lx64 macros to be used for > that. Using extra '_' to ease up the reading and differentiate > them from standard PRI*64 macros.
I think we should take advantage of this moment to rename those structs to have the 'perf_record_' prefix on them, I guess we could even remove the _event from them, i.e.: 'struct mmap_event' becomes 'perf_record_mmap', as it is the description for the PERF_RECORD_MMAP meta-data event, are you ok with that? I can go ahead and do it myself, updating each patch on this series to do that. - Arnaldo > It's also available in here: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > perf/fixes > > thanks, > jirka > > > --- > Jiri Olsa (12): > libperf: Add mmap_event to perf/event.h > libperf: Add mmap2_event to perf/event.h > libperf: Add comm_event to perf/event.h > libperf: Add namespaces_event to perf/event.h > libperf: Add fork_event to perf/event.h > libperf: Add lost_event to perf/event.h > libperf: Add lost_samples_event to perf/event.h > libperf: Add read_event to perf/event.h > libperf: Add throttle_event to perf/event.h > libperf: Add ksymbol_event to perf/event.h > libperf: Add bpf_event to perf/event.h > libperf: Add sample_event to perf/event.h > > tools/perf/builtin-sched.c | 2 +- > tools/perf/lib/include/perf/event.h | 112 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tools/perf/util/event.c | 12 ++++++------ > tools/perf/util/event.h | 104 > +++----------------------------------------------------------------------------------------------------- > tools/perf/util/evlist.c | 2 +- > tools/perf/util/evsel.c | 8 ++++---- > tools/perf/util/machine.c | 4 ++-- > tools/perf/util/python.c | 14 +++++++------- > tools/perf/util/session.c | 8 ++++---- > 9 files changed, 140 insertions(+), 126 deletions(-) > create mode 100644 tools/perf/lib/include/perf/event.h -- - Arnaldo
