On Mon, Aug 26, 2019 at 04:24:20PM +0800, Shaokun Zhang wrote: > > The other problem with this patch is that it initializes > > es_stats_cache_hits and es_stats_cache_miesses too late. They will > > get used when the journal inode is loaded. This is mostly harmless, > > I have checked it again, @es_stats_cache_hits and @es_stats_cache_miesses > have been initialized before the journal inode is loaded, Maybe I miss > something else?
No, sorry, that was my mistake. I misread things when I was looking over your patch last night. Please resubmit your patch once you've fixed things up and tested it. I would recommend that you at least try running your patch using the kvm-xfstests's smoke test[1] before submitting them. It will save you and me time. [1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md Thanks, - Ted
