On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote: > On Fri, 2019-08-23 at 19:14 +0000, Forrest Fleming wrote: > > suggested by checkpatch > > > > Signed-off-by: Forrest Fleming <fflem...@gmail.com> > > --- > > .../net/ethernet/intel/e1000/e1000_param.c | 28 +++++++++---------- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > While I do not see an issue with this change, I wonder how important it is > to make such a change. Especially since most of the hardware supported by > this driver is not available for testing. In addition, this is one > suggested change by checkpatch.pl that I personally do not agree with.
I think checkpatch should allow consecutive }}. Maybe: --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 287fe73688f0..ac5e0f06e1af 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4687,7 +4687,7 @@ sub process { # closing brace should have a space following it when it has anything # on the line - if ($line =~ /}(?!(?:,|;|\)))\S/) { + if ($line =~ /}(?!(?:,|;|\)|\}))\S/) { if (ERROR("SPACING", "space required after that close brace '}'\n" . $herecurr) && $fix) {