On Wed, Aug 28, 2019 at 12:10 PM Enric Balletbo i Serra
<[email protected]> wrote:
> On 27/8/19 18:12, Arnd Bergmann wrote:
> > On Tue, Aug 27, 2019 at 6:08 PM Bjorn Andersson
> > <[email protected]> wrote:
> >>
> >> On Tue 27 Aug 08:48 PDT 2019, Enric Balletbo i Serra wrote:
> >>
> >>> Recently we refactored the CrOS EC drivers moving part of the code from
> >>> the MFD subsystem to the platform chrome subsystem. During this change
> >>> we needed to rename some config options, so, update the defconfigs
> >>> accordingly.
> >>>
> >>> Signed-off-by: Enric Balletbo i Serra <[email protected]>
> >>> Acked-by: Krzysztof Kozlowski <[email protected]>
> >>> Reviewed-by: Gwendal Grignou <[email protected]>
> >>> Tested-by: Gwendal Grignou <[email protected]>
> >>
> >> Can we make the entries in the generic arm64 defconfig modules?
> >
> > Good idea.
> >
> > Actually I would prefer to have all of them as modules for consistency,
> > if at all possible.
> >
>
> It is very common boot Chromebooks from an USB device, the EC needs to be
> built-in in order to boot from these devices, otherwise you should use an
> initramfs. I'd like to avoid forcing people to build an initramfs just to boot
> from these devices if possible, in fact, my usual workflow is without
> initramfs,
> and knowing that with the default defconfig just should boot helps a lot
> sometimes.
>
> Note that, it's not the case for EC subdevices, these are already build as
> modules.
Ok, fair enough, let's leave it built-in then.
> BTW, Lee asked if this patch should be squashed with the patches that really
> renames the config options to help bisect ability, I don't have a hard opinion
> as I don't usually run the config option between bisection steps, so please
> let
> me know what do you prefer and I'll respin the patches ASAP if that's the
> case.
I'm not usually worried about bisection in defconfig changes, since like you
say most commonly one would not run 'make defconfig' betweens the
bisection steps.
If we really care about it, we could keep a symbol like this
in drivers/platform/chrome/Kconfig for one release:
config CONFIG_MFD_CROS_EC
tristate "Enable ChromeOS Embedded Controller"
select CROS_EC
select CHROME_PLATFORMS
select CONFIG_MFD_CROS_EC_DEV
help
This is a transitional Kconfig option and will be removed
after everyone enables the parts individually.
Arnd
