On Thu, Sep 05, 2019 at 03:44:33PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" <bfie...@redhat.com> > > It's easier to do this in string_escape_mem now. > > Might also consider non-ascii and quote-mark sprintf modifiers and then > we might make do with seq_printk.
No SoB :-) Entire series forgot to include RFC prefix. Nevertheless, this one I like independently on what we decide about flags. > - ret = string_escape_mem_ascii(src, isz, buf, size); > + ret = string_escape_mem(src, isz, buf, size, ESCAPE_NP|ESCAPE_NONASCII| > + ESCAPE_STYLE_SLASH|ESCAPE_STYLE_HEX, "\"\\"); Perhaps, unsigned int flags = FLAG1 | FLAG2 ...; -- With Best Regards, Andy Shevchenko