On Fri, Sep 6, 2019 at 11:34 AM chunguo feng <chunguo.f...@amlogic.com> wrote: > > From: fengchunguo <chunguo.f...@amlogic.com> > > This patch avoids fastopen_rsk not be cleared every times, then occur > the below BUG_ON: > tcp_v4_destroy_sock > ->BUG_ON(tp->fastopen_rsk); > > When playback some videos from netwrok,used tcp_disconnect continually.
Wow, tcp_disconnect() being used by something else than syzkaller ! > kthread+0x114/0x140 > ret_from_fork+0x10/0x18 > > Signed-off-by: fengchunguo <chunguo.f...@amlogic.com> > --- > net/ipv4/tcp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index 61082065b26a..f5c354c0b24c 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -2655,6 +2655,7 @@ int tcp_disconnect(struct sock *sk, int flags) > /* Clean up fastopen related fields */ > tcp_free_fastopen_req(tp); > inet->defer_connect = 0; > + tp->fastopen_rsk = 0; > > WARN_ON(inet->inet_num && !icsk->icsk_bind_hash); > This seems suspicious to me. Are we leaking a block of memory after your patch ? If the block of memory has been freed, maybe clear the pointer at the place the free happened ? I am traveling to Lisbon for LPC, maybe Yuchung or Neal can take a look.
