On Thu, Sep 05, 2019 at 12:22:06AM +0300, Ivan Khoronzhuk wrote: > No need to set --target for native build, at least for arm, the > default target will be used anyway. In case of arm, for at least > clang 5 - 10 it causes error like: > > clang: warning: unknown platform, assuming -mfloat-abi=soft > LLVM ERROR: Unsupported calling convention > make[2]: *** [/home/root/snapshot/samples/bpf/Makefile:299: > /home/root/snapshot/samples/bpf/sockex1_kern.o] Error 1 > > Only set to real triple helps: --target=arm-linux-gnueabihf > or just drop the target key to use default one. Decision to just > drop it and thus default target will be used (wich is native), > looks better. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org> > --- > samples/bpf/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile > index 61b7394b811e..a2953357927e 100644 > --- a/samples/bpf/Makefile > +++ b/samples/bpf/Makefile > @@ -197,8 +197,6 @@ BTF_PAHOLE ?= pahole > ifdef CROSS_COMPILE > HOSTCC = $(CROSS_COMPILE)gcc > CLANG_ARCH_ARGS = --target=$(notdir $(CROSS_COMPILE:%-=%)) > -else > -CLANG_ARCH_ARGS = -target $(ARCH) > endif
I don't follow here. Didn't you introduce this bug in patch 1 and now fixing it in patch 2?
