Re: [PATCH v2 2/3] media: Add lane checks for Cadence CSI2RX

[Jan Kotas]

Hello Sakari,

Thanks for your reply.
> On 6 Sep 2019, at 09:54, Sakari Ailus <sakari.ai...@iki.fi> wrote:
> 
> Hi Jan,
> 
> Thanks for the patchset.
> 
> On Thu, Sep 05, 2019 at 11:56:00AM +0100, Jan Kotas wrote:
>> /*
>>  * Driver for Cadence MIPI-CSI2 RX Controller v1.3
>>  *
>> - * Copyright (C) 2017 Cadence Design Systems Inc.
>> + * Copyright (C) 2017-2019 Cadence Design Systems Inc.
>>  */
>> 
>> +    for (i = 0; i < csi2rx->num_lanes; i++) {
>> +            if (csi2rx->lanes[i] < 1) {
> 
> Do you need this? v4l2_fwnode_parse_endpoint() already has a more thorough
> check for the lane numbers.

I looked at the source code of v4l2_fwnode_endpoint_parse_csi2_bus
and this particular case doesn’t seem to be checked.

> 
> -- 
> Regards,
> 
> Sakari Ailus

Regards,
Jan