Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller

[Michael Büsch]

On Fri,  6 Sep 2019 16:40:53 +0100
Colin King <colin.k...@canonical.com> wrote:

> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index da2d2ab8104d..7c3ae52f2b15 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const 
> u16 *in)
>  {
>       int i;
>       u16 o;
> -     u16 pwr_info_offset[] = {
> +     static const u16 pwr_info_offset[] = {
>               SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
>               SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
>       };

Thanks for your contribution. This change makes sense.

Kalle, can you please take it?

Acked-by: Michael Büsch <m...@bues.ch>

-- 
Michael

pgpySXyseXA2l.pgp
Description: OpenPGP digital signature