On Fri, Sep 21, 2007 at 12:38:03PM -0700, David Rientjes wrote: > On Fri, 21 Sep 2007, Alexey Dobriyan wrote: > > > > Move the OOM killer's extern function prototypes to include/linux/oom.h > > > and > > > include it where necessary. > > > > > > Cc: Andrea Arcangeli <[EMAIL PROTECTED]> > > > Acked-by: Christoph Lameter <[EMAIL PROTECTED]> > > > > NAK. Target in corresponding Kbuild is wrong. sched.h is overkill. > > Could we please also drop extern's while in protos? > > > > I'll prevent including sched.h in a follow-up patchset that I'll be > posting soon (and you'll be Cc'd). Which Kbuild target are you referring > to?
It's header-y vs unifdef-y in include/linux/Kbuild. The former is for plain headers exported to userspace as-is. The latter need preprocessing to remove __KERNEL__, CONFIG_*, etc. Since you're going to clutter oom.h with some purely internal protos, preprocessing should be done as well ;-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
