> On Sep 13, 2019, at 4:26 PM, Sami Tolvanen <samitolva...@google.com> wrote: > >> On Fri, Sep 13, 2019 at 3:45 PM Andy Lutomirski <l...@kernel.org> wrote: >> Should this be SYSCALL_DEFINE0? > > It can be, and that would also fix the issue. However, it does result > in unnecessary error injection to be hooked up here, which is why > arm64 preferred to avoid the macro when I fixed it there. S390 uses > SYSCALL_DEFINE0 for this though and since sys_ni_syscall always > returns -ENOSYS, it shouldn't be a huge problem. Thoughts? > I don’t see why all syscalls except these few should have error injection hooked up. It’s also IMO nicer from a maintenance perspective to have all syscalls use the same macros. Will, is there something I’m missing?
- [PATCH 0/4] x86: fix syscall function type mismatches Sami Tolvanen
- [PATCH 1/4] x86: use the correct function type in SYS... Sami Tolvanen
- Re: [PATCH 1/4] x86: use the correct function typ... Andy Lutomirski
- [PATCH 2/4] x86: use the correct function type for sy... Sami Tolvanen
- Re: [PATCH 2/4] x86: use the correct function typ... Andy Lutomirski
- Re: [PATCH 2/4] x86: use the correct function... Sami Tolvanen
- [PATCH 3/4] x86: use the correct function type for sy... Sami Tolvanen
- Re: [PATCH 3/4] x86: use the correct function typ... Andy Lutomirski
- Re: [PATCH 3/4] x86: use the correct function... Sami Tolvanen
- Re: [PATCH 3/4] x86: use the correct func... Andy Lutomirski
- Re: [PATCH 3/4] x86: use the correct... Will Deacon
- [PATCH 4/4] x86: fix function types in COND_SYSCALL Sami Tolvanen
- Re: [PATCH 4/4] x86: fix function types in COND_S... Andy Lutomirski
- Re: [PATCH 4/4] x86: fix function types in CO... Sami Tolvanen
- Re: [PATCH 4/4] x86: fix function types i... Andy Lutomirski
- Re: [PATCH 4/4] x86: fix function ty... Sami Tolvanen