On 2019-09-16 11:19, Mika Westerberg wrote: > On Mon, Sep 16, 2019 at 09:12:50AM +0000, Jethro Beekman wrote: >> On 2019-09-16 11:11, Mika Westerberg wrote: >>> Hi, >>> >>> On Sun, Sep 15, 2019 at 08:41:55PM +0000, Jethro Beekman wrote: >>>> Could someone please review this? >>>> >>>> On 2019-09-04 03:15, Jethro Beekman wrote: >>>>> Some flash controllers don't have a software sequencer. Avoid >>>>> configuring the register addresses for it, and double check >>>>> everywhere that its not accidentally trying to be used. >>> >>> All the supported types in intel_spi_init() set ->sregs so I don't see >>> how we could end up calling functions with that not set properly. Which >>> controller we are talking about here? CNL? >>> >> >> Yes, see 2/2. > > OK, thanks. Please mention that in the commit log as well.
It seems obvious to me that the need for a patch may be further explained by the next patch in the patch set. -- Jethro Beekman | Fortanix
