Instead use devm_regulator_get_optional since the regulator
is optional and check for errors.

Signed-off-by: Guido Günther <a...@sigxcpu.org>
---
 drivers/leds/leds-lm3692x.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index f394669ad8f2..9972c932d51e 100644
--- a/drivers/leds/leds-lm3692x.c
+++ b/drivers/leds/leds-lm3692x.c
@@ -333,9 +333,14 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
                return ret;
        }
 
-       led->regulator = devm_regulator_get(&led->client->dev, "vled");
-       if (IS_ERR(led->regulator))
-               led->regulator = NULL;
+       led->regulator = devm_regulator_get_optional(&led->client->dev, "vled");
+       if (IS_ERR(led->regulator)) {
+               ret = PTR_ERR(led->regulator);
+               if (ret != -EPROBE_DEFER)
+                       dev_err(&led->client->dev,
+                               "Failed to get vled regulator: %d\n", ret);
+               return ret;
+       }
 
        child = device_get_next_child_node(&led->client->dev, child);
        if (!child) {
-- 
2.23.0.rc1

Reply via email to