On 19-09-17 17:57, Dmitry Torokhov wrote: > On Tue, Sep 17, 2019 at 4:42 PM Marco Felsch <[email protected]> wrote: > > > > Sometimes it can happen that the regulator_of_get_init_data() can't > > retrieve the config due to a not probed device the regulator depends on. > > Fix that by checking the return value of of_parse_cb() and return > > EPROBE_DEFER in such cases. > > Treating EPROBE_DEFER in a special way is usually wrong. > regulator_of_get_init_data() may fail for multiple reasons (no memory, > invalid DT, etc, etc). All of them should abort instantiating > regulator.
Those errors are handled but the behaviour of this funciton is to return NULL in such errors which is fine for the caller of this function. I only want to handle EPROBE_DEFER special.. Regards, Marco > Thanks. > > -- > Dmitry > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
