+ Masami. On Sun, Sep 22, 2019 at 06:03:28PM +0300, Alexander Kapshuk wrote: > This patch fixes the regexp warnings shown below:
Avoid having "This patch" or "This commit" in the commit message. It is tautologically useless. Also, do $ git grep 'This patch' Documentation/process for more details. > GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape > sequence `\:' is not a known regexp operator > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: > (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape > sequence `\&' is not a known regexp operator > > The ':' and '&' characters need not escaping when used in string constants > as part of regular expressions. I could use a reasoning here, as in, "gawk manual doesn't have those two characters in the list here: https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html"; or so. > > [Test-run] > awk -f arch/x86/tools/gen-insn-attr-x86.awk \ > arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.c > > diff arch/x86/lib/inat-tables.c ~/tmp/inat-tables.c; echo $? > 0 > > awk -f tools/arch/x86/tools/gen-insn-attr-x86.awk \ > tools/arch/x86/lib/x86-opcode-map.txt >../tmp/inat-tables.c > > diff tools/objtool/arch/x86/lib/inat-tables.c ~/tmp/inat-tables.c; echo $? > 0 No need for that - just say that diffing the output before and after shows no changes. > [Debugging output] > DBG:ext:(66&F2) > DBG:match(ext, ...):(66&F2) > DBG:match(..., lprefix3_expr):\((F2|!F3|66&F2)\) That is supposed to say what exactly? That it still does what it is expected to do? Leaving in the rest for Masami. Thx. > Signed-off-by: Alexander Kapshuk <alexander.kaps...@gmail.com> > Reported-by: kbuild test robot <l...@intel.com> > --- > arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- > tools/arch/x86/tools/gen-insn-attr-x86.awk | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/tools/gen-insn-attr-x86.awk > b/arch/x86/tools/gen-insn-attr-x86.awk > index b02a36b2c14f..a42015b305f4 100644 > --- a/arch/x86/tools/gen-insn-attr-x86.awk > +++ b/arch/x86/tools/gen-insn-attr-x86.awk > @@ -69,7 +69,7 @@ BEGIN { > > lprefix1_expr = "\\((66|!F3)\\)" > lprefix2_expr = "\\(F3\\)" > - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" > + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" > lprefix_expr = "\\((66|F2|F3)\\)" > max_lprefix = 4 > > @@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) > return add_flags(imm, mod) > } > > -/^[0-9a-f]+\:/ { > +/^[0-9a-f]+:/ { > if (NR == 1) > next > # get index > diff --git a/tools/arch/x86/tools/gen-insn-attr-x86.awk > b/tools/arch/x86/tools/gen-insn-attr-x86.awk > index b02a36b2c14f..a42015b305f4 100644 > --- a/tools/arch/x86/tools/gen-insn-attr-x86.awk > +++ b/tools/arch/x86/tools/gen-insn-attr-x86.awk > @@ -69,7 +69,7 @@ BEGIN { > > lprefix1_expr = "\\((66|!F3)\\)" > lprefix2_expr = "\\(F3\\)" > - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)" > + lprefix3_expr = "\\((F2|!F3|66&F2)\\)" > lprefix_expr = "\\((66|F2|F3)\\)" > max_lprefix = 4 > > @@ -257,7 +257,7 @@ function convert_operands(count,opnd, i,j,imm,mod) > return add_flags(imm, mod) > } > > -/^[0-9a-f]+\:/ { > +/^[0-9a-f]+:/ { > if (NR == 1) > next > # get index > -- > 2.23.0 > -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
