On Sun, Sep 22, 2019 at 10:32 AM Arvind Sankar <nived...@alum.mit.edu> wrote: > > Hi, since commit b059f801a937 (x86/purgatory: Use CFLAGS_REMOVE rather > than reset KBUILD_CFLAGS) kexec is broken if GCC_PLUGIN_STACKLEAK is > enabled, as the purgatory contains undefined references to > stackleak_track_stack. > > Attempting to load a kexec kernel results in an error: > > kexec: Undefined symbol: stackleak_track_stack > kexec-bzImage64: Loading purgatory failed > > Adding $(DISABLE_STACKLEAK_PLUGIN) to PURGATORY_CFLAGS in > arch/x86/purgatory/Makefile fixes this.
Hi Arvind, Thanks for the report. That sounds like a straightforward fix. Would you like to send a patch for that? I'd be happy to help review it. > > Not sure if that's the best fix or if other architectures also require a > similar one. The commit you reference should be x86 only. -- Thanks, ~Nick Desaulniers
