On Tue, 2007-09-25 at 14:08 +0200, Rafael J. Wysocki wrote:
> Hi,
>
> This patch from Andi:
>
> x86_64-mm-cpa-einval.patch
>
> makes the hda_intel audio driver stop working on my HP nx6325.
>
> The following line appears in dmesg (from 2.6.23-rc7-mm1:
>
> ALSA /home/rafael/src/mm/linux-2.6.23-rc7-mm1/sound/pci/hda/hda_intel.c:1755:
> hd
> a-intel: ioremap error
>
> and the driver doesn't work afterwards.
>
> Still, I'm not sure if the patch above is wrong or rather it exposes a problem
> in the driver.
The patch is correct. Instead of returning "Success" in the case of a
failure of lookup_address, it now returns -EINVAL, which in turn makes
the ioremap fail.
OTOH, the driver ioremap call looks straight forward. Can you apply the
patch below and provide the resulting debug output please ?
Thanks,
tglx
Index: linux-2.6.23-rc8-mm/arch/x86_64/mm/pageattr.c
===================================================================
--- linux-2.6.23-rc8-mm.orig/arch/x86_64/mm/pageattr.c 2007-09-25
14:05:41.000000000 +0200
+++ linux-2.6.23-rc8-mm/arch/x86_64/mm/pageattr.c 2007-09-25
14:09:35.000000000 +0200
@@ -156,8 +156,10 @@ __change_page_attr(unsigned long address
pgprot_t ref_prot2;
kpte = lookup_address(address);
- if (!kpte)
+ if (!kpte) {
+ printk("lookup failed for %lu\n", address);
return -EINVAL;
+ }
kpte_page = virt_to_page(((unsigned long)kpte) & PAGE_MASK);
BUG_ON(PageCompound(kpte_page));
Index: linux-2.6.23-rc8-mm/sound/pci/hda/hda_intel.c
===================================================================
--- linux-2.6.23-rc8-mm.orig/sound/pci/hda/hda_intel.c 2007-09-25
14:05:43.000000000 +0200
+++ linux-2.6.23-rc8-mm/sound/pci/hda/hda_intel.c 2007-09-25
14:09:28.000000000 +0200
@@ -1752,7 +1752,8 @@ static int __devinit azx_create(struct s
chip->addr = pci_resource_start(pci, 0);
chip->remap_addr = ioremap_nocache(chip->addr, pci_resource_len(pci,0));
if (chip->remap_addr == NULL) {
- snd_printk(KERN_ERR SFX "ioremap error\n");
+ snd_printk(KERN_ERR SFX "ioremap error: %lu %lu\n",
+ chip->addr, pci_resource_len(pci, 0));
err = -ENXIO;
goto errout;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
