Dan,
On 9/25/19 7:46 PM, Dan Murphy wrote:
> Update the DT binding to include the properties to use the
> multicolor framework for the devices that use the LP55xx
> framework.
>
> Signed-off-by: Dan Murphy <dmur...@ti.com>
> CC: Tony Lindgren <t...@atomide.com>
> CC: "Benoît Cousson" <bcous...@baylibre.com>
> CC: Linus Walleij <linus.wall...@linaro.org>
> CC: Shawn Guo <shawn...@kernel.org>
> CC: Sascha Hauer <s.ha...@pengutronix.de>
> CC: Pengutronix Kernel Team <ker...@pengutronix.de>
> CC: Fabio Estevam <feste...@gmail.com>
> CC: NXP Linux Team <linux-...@nxp.com>
> ---
> .../devicetree/bindings/leds/leds-lp55xx.txt | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
> b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
> index bfe2805c5534..c120d2bde3bd 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
> @@ -1,6 +1,8 @@
> Binding for TI/National Semiconductor LP55xx LED Drivers
>
> Required properties:
> +- #address-cells: 1
> +- #size-cells: 0
> - compatible: one of
> national,lp5521
> national,lp5523
> @@ -14,6 +16,18 @@ Required properties:
> Each child has own specific current settings
> - led-cur: Current setting at each LED channel (mA x10, 0 if LED is not
> connected)
> - max-cur: Maximun current at each LED channel.
> +- reg: Output channel for the LED. This is zero based channel identifier and
> + the data sheet is a one based channel identifier.
> + reg value to output to LED output number
> + D1 = reg value is 0
> + D2 = reg value is 1
> + D3 = reg value is 2
> + D4 = reg value is 3
> + D5 = reg value is 4
> + D6 = reg value is 5
> + D7 = reg value is 6
> + D8 = reg value is 7
> + D9 = reg value is 8
>
> Optional properties:
> - enable-gpio: GPIO attached to the chip's enable pin
> @@ -35,23 +49,28 @@ example 1) LP5521
> on channel 0.
>
> lp5521@32 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> compatible = "national,lp5521";
> reg = <0x32>;
> label = "lp5521_pri";
> clock-mode = /bits/ 8 <2>;
>
> chan0 {
s/chan0/chan@0/
The same applies to the remaining occurrences in this file and to
the other patches from the patch set as already pointed out.
> + reg = <0>;
> led-cur = /bits/ 8 <0x2f>;
> max-cur = /bits/ 8 <0x5f>;
> linux,default-trigger = "heartbeat";
> };
>
--
Best regards,
Jacek Anaszewski
