On 25.09.19 22:03, Dexuan Cui wrote: >> From: [email protected] >> [... snipped ...] >>> Anyhow, just some comments from my side :) I can see how Windows Server >>> worked around that issue right now by just XOR'ing both features. >>> >>> David / dhildenb >> >> Thanks for sharing your thoughts! >> >> -- Dexuan > > Hi David, > If my explanation sounds good to you, can I have an Acked-by from you? >
I do ACK the approach but not the patch in it's current state. I don't like the ifdefs - once you can get rid of the ifdefery - e.g., after the prerequisite is upstream - you can add my Acked-by: David Hildenbrand <[email protected]> -- Thanks, David / dhildenb
