Let ARC to use the new helper fault_signal_pending() by moving the
signal check out of the retry logic as standalone.  This should also
helps to simplify the code a bit.

Signed-off-by: Peter Xu <pet...@redhat.com>
---
 arch/arc/mm/fault.c | 34 +++++++++++++---------------------
 1 file changed, 13 insertions(+), 21 deletions(-)

diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c
index 3861543b66a0..ee3ba7c7b891 100644
--- a/arch/arc/mm/fault.c
+++ b/arch/arc/mm/fault.c
@@ -127,29 +127,21 @@ void do_page_fault(unsigned long address, struct pt_regs 
*regs)
 
        fault = handle_mm_fault(vma, address, flags);
 
+       /* Quick path to respond to signals */
+       if (fault_signal_pending(fault, regs)) {
+               if (!user_mode(regs))
+                       goto no_context;
+               return;
+       }
+
        /*
-        * Fault retry nuances
+        * Fault retry nuances, mmap_sem already relinquished by core mm
         */
-       if (unlikely(fault & VM_FAULT_RETRY)) {
-
-               /*
-                * If fault needs to be retried, handle any pending signals
-                * first (by returning to user mode).
-                * mmap_sem already relinquished by core mm for RETRY case
-                */
-               if (fatal_signal_pending(current)) {
-                       if (!user_mode(regs))
-                               goto no_context;
-                       return;
-               }
-               /*
-                * retry state machine
-                */
-               if (flags & FAULT_FLAG_ALLOW_RETRY) {
-                       flags &= ~FAULT_FLAG_ALLOW_RETRY;
-                       flags |= FAULT_FLAG_TRIED;
-                       goto retry;
-               }
+       if (unlikely((fault & VM_FAULT_RETRY) &&
+                    (flags & FAULT_FLAG_ALLOW_RETRY))) {
+               flags &= ~FAULT_FLAG_ALLOW_RETRY;
+               flags |= FAULT_FLAG_TRIED;
+               goto retry;
        }
 
 bad_area:
-- 
2.21.0

Reply via email to