On Fri, Sep 27, 2019 at 12:49 AM Jose Abreu <jose.ab...@synopsys.com> wrote:
>
> The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it.
I think the warning was from -Wsizeof-array-div.
>
> Reported-by: kbuild test robot <l...@intel.com>
> Reported-by: Nick Desaulniers <ndesaulni...@google.com>
I may have reported the kbuild link, but scanning my email, there's
also a report from
Reported-by: Nathan Chancellor <natechancel...@gmail.com>
> Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core")
> Signed-off-by: Jose Abreu <jose.ab...@synopsys.com>
>
> ---
> Cc: Giuseppe Cavallaro <peppe.cavall...@st.com>
> Cc: Alexandre Torgue <alexandre.tor...@st.com>
> Cc: Jose Abreu <joab...@synopsys.com>
> Cc: "David S. Miller" <da...@davemloft.net>
> Cc: Maxime Coquelin <mcoquelin.st...@gmail.com>
> Cc: net...@vger.kernel.org
> Cc: linux-st...@st-md-mailman.stormreply.com
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Nick Desaulniers <ndesaulni...@google.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> index 6d8ac2ef4fc2..4a1f52474dbc 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> @@ -533,7 +533,7 @@ static int dwxgmac2_rss_configure(struct mac_device_info
> *hw,
> return 0;
> }
>
> - for (i = 0; i < (sizeof(cfg->key) / sizeof(u32)); i++) {
> + for (i = 0; i < (ARRAY_SIZE(cfg->key) / sizeof(u32)); i++) {
cfg is an instance of struct stmmac_rss, which looks like:
125 struct stmmac_rss {
126 int enable;
127 u8 key[STMMAC_RSS_HASH_KEY_SIZE];
128 u32 table[STMMAC_RSS_MAX_TABLE_SIZE];
129 };
yep, LGTM. Thanks for the patch.
Reviewed-by: Nick Desaulniers <ndesaulni...@google.com>
> ret = dwxgmac2_rss_write_reg(ioaddr, true, i, cfg->key[i]);
> if (ret)
> return ret;
> --
> 2.7.4
>
--
Thanks,
~Nick Desaulniers
