On Fri, Jan 04, 2019 at 09:30:09PM +0200, Andy Shevchenko wrote: > Use %ptT instead of open coded variant to print content of > time64_t type in human readable format. > > Cc: Mathias Nyman <mathias.ny...@intel.com> > Cc: Thierry Reding <thierry.red...@gmail.com> > Cc: Jonathan Hunter <jonath...@nvidia.com> > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > drivers/usb/host/xhci-tegra.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c > index 938ff06c0349..ed3eea3876e2 100644 > --- a/drivers/usb/host/xhci-tegra.c > +++ b/drivers/usb/host/xhci-tegra.c > @@ -820,7 +820,6 @@ static int tegra_xusb_load_firmware(struct tegra_xusb > *tegra) > const struct firmware *fw; > unsigned long timeout; > time64_t timestamp; > - struct tm time; > u64 address; > u32 value; > int err; > @@ -925,11 +924,8 @@ static int tegra_xusb_load_firmware(struct tegra_xusb > *tegra) > } > > timestamp = le32_to_cpu(header->fwimg_created_time); > - time64_to_tm(timestamp, 0, &time); > > - dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n", > - time.tm_year + 1900, time.tm_mon + 1, time.tm_mday, > - time.tm_hour, time.tm_min, time.tm_sec); > + dev_info(dev, "Firmware timestamp: %ptT UTC\n", ×tamp);
If I understand correctly, this will now print: Firmware timestamp: YYYY-mm-ddTHH:MM:SS UTC whereas it earlier printed: Firmware timestamp: YYYY-mm-dd HH:MM:SS UTC So the 'T' character is different now. Could we make this something along the lines of: dev_info(dev, "Firmware timestamp: %ptTd %ptTt UTC\n", ×tamp, ×tamp); To keep the output identical? It's possible that there are some scripts that parse the log to find out which firmware was loaded. Thierry
signature.asc
Description: PGP signature