Hi Peter, On 27/08/2019 20:06, Peter Zijlstra wrote: > Adding another text_poke_bp_batch() user made me realize the interface > is all sorts of wrong. The text poke vector should be internal to the > implementation. > > This then results in a trivial interface: > > text_poke_queue() - which has the 'normal' text_poke_bp() interface > text_poke_finish() - which takes no arguments and flushes any > pending text_poke()s.
I liked the changes. My only concern is about the internal vector. I thought about making it internal in the past, but I chose to make it "per use-case" because there might cases in which more entries would be needed, without the restriction of using static memory. This might be the ftrace case... [ more in the next email ]. -- Daniel
