On Wed, Oct 02, 2019 at 09:46:42AM -0700, Andi Kleen wrote: > From: Andi Kleen <[email protected]> > > The original --reltime patch forbid --time with --reltime. > > But it turns out --time doesn't really care about --reltime, because > the relative time is only used at final output, while > the time filtering always works earlier on absolute time. > > So just remove the check and allow combining the two options. > > Fixes: 90b10f47c0ee ("perf script: Support relative time") > Signed-off-by: Andi Kleen <[email protected]>
Acked-by: Jiri Olsa <[email protected]> thanks, jirka > --- > tools/perf/builtin-script.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index 32b17d51c982..7481003b2761 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -3601,11 +3601,6 @@ int cmd_script(int argc, const char **argv) > } > } > > - if (script.time_str && reltime) { > - fprintf(stderr, "Don't combine --reltime with --time\n"); > - return -1; > - } > - > if (itrace_synth_opts.callchain && > itrace_synth_opts.callchain_sz > scripting_max_stack) > scripting_max_stack = itrace_synth_opts.callchain_sz; > -- > 2.21.0 >
