On 2019-10-03, Christian Brauner <christ...@brauner.io> wrote: > On Thu, Oct 3, 2019, 19:11 Nathan Chancellor <natechancel...@gmail.com> > wrote: > > > Clang warns: > > > > lib/test_user_copy.c:96:10: warning: using the result of an assignment > > as a condition without parentheses [-Wparentheses] > > if (ret |= test(umem_src == NULL, "kmalloc failed")) > > ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > lib/test_user_copy.c:96:10: note: place parentheses around the > > assignment to silence this warning > > if (ret |= test(umem_src == NULL, "kmalloc failed")) > > ^ > > ( ) > > lib/test_user_copy.c:96:10: note: use '!=' to turn this compound > > assignment into an inequality comparison > > if (ret |= test(umem_src == NULL, "kmalloc failed")) > > ^~ > > != > > > > Add the parentheses as it suggests because this is intentional. > > > > Fixes: f5a1a536fa14 ("lib: introduce copy_struct_from_user() helper") > > Link: https://github.com/ClangBuiltLinux/linux/issues/731 > > Signed-off-by: Nathan Chancellor <natechancel...@gmail.com> > > > > I'll take this. Aleksa, can I get your ack too, please? > > Acked-by: Christian Brauner <christian.brau...@ubuntu.com>
Acked-by: Aleksa Sarai <cyp...@cyphar.com> -- Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH <https://www.cyphar.com/>
signature.asc
Description: PGP signature