> From: Stefano Garzarella <sgarz...@redhat.com>
> Sent: Friday, September 27, 2019 4:27 AM
> To: net...@vger.kernel.org
> Cc: linux-hyp...@vger.kernel.org; KY Srinivasan <k...@microsoft.com>; Stefan
> Hajnoczi <stefa...@redhat.com>; Sasha Levin <sas...@kernel.org>;
> linux-kernel@vger.kernel.org; k...@vger.kernel.org; David S. Miller
> <da...@davemloft.net>; virtualizat...@lists.linux-foundation.org; Stephen
> Hemminger <sthem...@microsoft.com>; Jason Wang
> <jasow...@redhat.com>; Michael S. Tsirkin <m...@redhat.com>; Haiyang
> Zhang <haiya...@microsoft.com>; Dexuan Cui <de...@microsoft.com>;
> Jorgen Hansen <jhan...@vmware.com>
> Subject: [RFC PATCH 09/13] hv_sock: set VMADDR_CID_HOST in the
> hvs_remote_addr_init()
> 
> Remote peer is always the host, so we set VMADDR_CID_HOST as
> remote CID instead of VMADDR_CID_ANY.
> 
> Signed-off-by: Stefano Garzarella <sgarz...@redhat.com>
> ---
>  net/vmw_vsock/hyperv_transport.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/vmw_vsock/hyperv_transport.c
> b/net/vmw_vsock/hyperv_transport.c
> index 4f47af2054dd..306310794522 100644
> --- a/net/vmw_vsock/hyperv_transport.c
> +++ b/net/vmw_vsock/hyperv_transport.c
> @@ -186,7 +186,8 @@ static void hvs_remote_addr_init(struct sockaddr_vm
> *remote,
>       static u32 host_ephemeral_port = MIN_HOST_EPHEMERAL_PORT;
>       struct sock *sk;
> 
> -     vsock_addr_init(remote, VMADDR_CID_ANY, VMADDR_PORT_ANY);
> +     /* Remote peer is always the host */
> +     vsock_addr_init(remote, VMADDR_CID_HOST, VMADDR_PORT_ANY);
> 
>       while (1) {
>               /* Wrap around ? */
> --

Looks good to me, since hv_sock doesn't really use the CID in the 
transport layer.

Reviewed-by: Dexuan Cui <de...@microsoft.com>

Reply via email to