On 04/10/2019 11:48, Anshuman Khandual wrote: > > > On 10/04/2019 03:49 PM, Steven Price wrote: >> On 04/10/2019 05:23, Anshuman Khandual wrote: >>> Platform implementation for free_initmem() should poison the memory while >>> freeing it up. Hence pass across POISON_FREE_INITMEM while calling into >>> free_reserved_area(). The same is being followed in the generic fallback >>> for free_initmem() and some other platforms overriding it. >>> >>> Cc: Catalin Marinas <[email protected]> >>> Cc: Will Deacon <[email protected]> >>> Cc: Mark Rutland <[email protected]> >>> Cc: [email protected] >>> Signed-off-by: Anshuman Khandual <[email protected]> >> >> Is there a good reason you haven't made a similar change to >> free_initrd_mem() - the same logic seems to apply. However this change >> looks fine to me. > > We will use generic free_initrd_mem() going forward as proposed in a recent > patch which does call free_reserved_area() with POISON_FREE_INITMEM. > > https://patchwork.kernel.org/patch/11165379/
Great - that sounds like a very good reason! Thanks, Steve >> >> Reviewed-by: Steven Price <[email protected]> >> >>> --- >>> arch/arm64/mm/init.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >>> index 45c00a54909c..ea7d38011e83 100644 >>> --- a/arch/arm64/mm/init.c >>> +++ b/arch/arm64/mm/init.c >>> @@ -571,7 +571,7 @@ void free_initmem(void) >>> { >>> free_reserved_area(lm_alias(__init_begin), >>> lm_alias(__init_end), >>> - 0, "unused kernel"); >>> + POISON_FREE_INITMEM, "unused kernel"); >>> /* >>> * Unmap the __init region but leave the VM area in place. This >>> * prevents the region from being reused for kernel modules, which >>> >> >> > > _______________________________________________ > linux-arm-kernel mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
