On Mon, 7 Oct 2019 19:04:46 +0200
Sebastian Reichel <s...@kernel.org> wrote:
> Hi,
>
> On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote:
> > When the panels were moved from omap/displays/ to panel/
> > omapdss prefix was stripped, which cause spi modalias
> > to not contain the vendor-prefix anymore.
> >
> > so we had e.g. in former times:
> > compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1
> > now:
> > compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1
> >
> > This is consistent with other drivers. Tested the td028ttec.c
> > only, but the pattern looks the same for the other ones.
> >
> > Fixes: 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")
> > Signed-off-by: Andreas Kemnade <andr...@kemnade.info>
> > ---
>
> Patch looks good to me, but you have one false positive.
>
> > [...]
> >
> > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > index 46cd9a2501298..838d39a263f53 100644
> > --- a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > +++ b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> > @@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device
> > *pdev)
> > }
> >
> > static const struct of_device_id ls037v7dw01_of_match[] = {
> > - { .compatible = "sharp,ls037v7dw01", },
> > + { .compatible = "ls037v7dw01", },
> > { /* sentinel */ },
> > };
> >
>
> The DT compatible should have a vendor prefix.
>
oops, sorry, but I it seems that Laurent already has submitted a fix.
Regards,
Andreas
