User reports that an application making an (incorrect) call to
restart AN on a fixed link DPAA interface triggers an error in
the kernel log while the returned EINVAL should be enough.

Reported-by: Joakim Tjernlund <joakim.tjernl...@infinera.com>
Signed-off-by: Madalin Bucur <madalin.bu...@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c 
b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
index 1c689e11c61f..126c0f1d8442 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
@@ -81,7 +81,6 @@ static int dpaa_get_link_ksettings(struct net_device *net_dev,
                                   struct ethtool_link_ksettings *cmd)
 {
        if (!net_dev->phydev) {
-               netdev_dbg(net_dev, "phy device not initialized\n");
                return 0;
        }
 
@@ -96,7 +95,6 @@ static int dpaa_set_link_ksettings(struct net_device *net_dev,
        int err;
 
        if (!net_dev->phydev) {
-               netdev_err(net_dev, "phy device not initialized\n");
                return -ENODEV;
        }
 
@@ -143,7 +141,6 @@ static int dpaa_nway_reset(struct net_device *net_dev)
        int err;
 
        if (!net_dev->phydev) {
-               netdev_err(net_dev, "phy device not initialized\n");
                return -ENODEV;
        }
 
@@ -168,7 +165,6 @@ static void dpaa_get_pauseparam(struct net_device *net_dev,
        mac_dev = priv->mac_dev;
 
        if (!net_dev->phydev) {
-               netdev_err(net_dev, "phy device not initialized\n");
                return;
        }
 
-- 
2.1.0

Reply via email to