On Fri, Sep 28, 2007 at 09:08:47AM +0200, Nadia Derbey wrote: > Jarek Poplawski wrote: > >On Thu, Sep 27, 2007 at 04:33:55PM +0200, [EMAIL PROTECTED] wrote: > > > >>[PATCH 01/02] > >> > >> > >>This is a patch that fixes the way idr_find() used to be called in > >>ipc_lock(): > >>in all the paths that don't imply an update of the ipcs idr, it was called > >>without the idr tree being locked. > >> > >>The changes are: > >> . in ipc_ids, the mutex has been changed into a reader/writer semaphore. > >> . ipc_lock() now takes the mutex as a reader during the idr_find(). > >> . a new routine ipc_lock_down() has been defined: it doesn't take the > >> mutex, assuming that it is being held by the caller. This is the > >> routine > >> that is now called in all the update paths. > >> > >> > >>Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> > > > > > >Acked-by: Jarek Poplawski <[EMAIL PROTECTED]> > > > >PS: there is one big mistake around To/Cc ordering, so I doubt Andrew > >will ever sign this... > > > > > > Jarek, > > I thought that since you were the one who pointed out the issue I had to > put you as the receiver. > Next time I'll also add Andrew in the To list. > Sorry for that.
It seems Andrew is generous (sometimes) and should forgive you (some day...). And I'm perfectly happy. Of course, with Cc too. I'm only a bit confused with this 2/2, which is of course OK, but it seems my ack isn't needed there. Thanks, Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/