Den ons 9 okt. 2019 kl 20:08 skrev Steven Rostedt <rost...@goodmis.org>: > > On Wed, 9 Oct 2019 16:51:07 +0200 > Viktor Rosendahl <viktor.rosend...@gmail.com> wrote: > > > Apologies, I should have replied there but I have been a bit busy the > > last few days with other topics, and I felt a bit indecisive about > > that point, so I just sloppily addressed the issue in the cover letter > > of this new series: > > > > "I have retained the fourth patch, although it was suggested that is > > becoming > > obsolete soon. I have retained it only because I do not know the status of > > the code that will make it obsolete. It's the last patch of the series and > > if there indeed is some code that will remove the latency issues from the > > printk code, then of course it makes sense to drop it. The first three > > patches > > will work without it." > > > > I thought that, since it's the last in the series, it would be > > possible for maintainers to just take the first three if the last one > > is not wanted. > > > > For me it solves a rather important problem though, so if the code > > that will make it obsolete isn't available for some time, then perhaps > > it should be considered as a temporary solution. > > > > Of course, if there is a commitment to never remove any knobs from > > /sys/kernel/debug/tracing/trace_options, then I can easily understand > > that it's not wanted as a temporary fix. > > There isn't quite a commitment to not remove knobs, but if a tool > starts relying on a knob, then, the answer is yes there is :-p > > As this will hopefully become something we don't worry about in the > future, I would rather have this be a kernel command line option. This > way, it wont be something that tools can really check for. > > If you add a trace_console_latency option to the kernel command line, > we can enable it that way. And then when it becomes obsolete, we can > simply remove it, without breaking any tools. > > Would that work for you? >
Sounds good to me. I will try to adjust the patch accordingly within a few days. best regards, Viktor > -- Steve