In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 3e99cb214f03 ("soc: ti: add initial PRM driver with reset control 
support")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
 drivers/soc/ti/omap_prm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c
index db47a8bceb87..96c6f777519c 100644
--- a/drivers/soc/ti/omap_prm.c
+++ b/drivers/soc/ti/omap_prm.c
@@ -375,8 +375,8 @@ static int omap_prm_probe(struct platform_device *pdev)
        prm->data = data;
 
        prm->base = devm_ioremap_resource(&pdev->dev, res);
-       if (!prm->base)
-               return -ENOMEM;
+       if (IS_ERR(prm->base))
+               return PTR_ERR(prm->base);
 
        return omap_prm_reset_init(pdev, prm);
 }



Reply via email to