On Sep 27 2007 23:18, Vegard Nossum wrote: > * kprint_<level>() is better than kprint(<level), ) because in the > case of the default log-level, the argument can be omitted. > * Memory allocated for entries and arguments is done in a ring-buffer > with variable-sized chunks. Arguments are chained with a singly- > linked list. > * Use SUBSYSTEM and KBUILD_MODNAME > * Rename kprint buffers to kprint blocks
This is overall, quite a lot. I suggest one-thing-at-a-time, starting with kprint_<level>() that is compiled out if desired and no fancy block or newline stuff. _Then_, will see how it flies. All of this smells like a bit of overdesigning, aka http://en.wikipedia.org/wiki/YAGNI - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
