Hi Daniel, I love your patch! Perhaps something to improve:
[auto build test WARNING on soc-thermal/next] [cannot apply to v5.4-rc3 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-Move-default-governor-config-option-to-the-internal-header/20191014-103735 base: https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git next config: i386-randconfig-g003-201941 (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All warnings (new ones prefixed by >>): In file included from include/linux/export.h:45:0, from include/linux/linkage.h:7, from include/linux/kernel.h:8, from drivers/platform/x86/acerhdf.c:23: drivers/platform/x86/acerhdf.c: In function 'acerhdf_register_thermal': drivers/platform/x86/acerhdf.c:747:30: error: dereferencing pointer to incomplete type 'struct thermal_governor' if (strcmp(thz_dev->governor->name, ^ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ >> drivers/platform/x86/acerhdf.c:747:2: note: in expansion of macro 'if' if (strcmp(thz_dev->governor->name, ^~ vim +/if +747 drivers/platform/x86/acerhdf.c e86435eb91b2bf Peter Feuerer 2009-06-21 731 1d0c3fd01afbd5 Paul Gortmaker 2018-09-20 732 static int __init acerhdf_register_thermal(void) e86435eb91b2bf Peter Feuerer 2009-06-21 733 { e86435eb91b2bf Peter Feuerer 2009-06-21 734 cl_dev = thermal_cooling_device_register("acerhdf-fan", NULL, e86435eb91b2bf Peter Feuerer 2009-06-21 735 &acerhdf_cooling_ops); e86435eb91b2bf Peter Feuerer 2009-06-21 736 e86435eb91b2bf Peter Feuerer 2009-06-21 737 if (IS_ERR(cl_dev)) e86435eb91b2bf Peter Feuerer 2009-06-21 738 return -EINVAL; e86435eb91b2bf Peter Feuerer 2009-06-21 739 7e8b6d737da9c6 Peter Feuerer 2014-11-28 740 thz_dev = thermal_zone_device_register("acerhdf", 2, 0, NULL, 48c8dd64345ba2 Peter Feuerer 2014-11-28 741 &acerhdf_dev_ops, 48c8dd64345ba2 Peter Feuerer 2014-11-28 742 &acerhdf_zone_params, 0, e86435eb91b2bf Peter Feuerer 2009-06-21 743 (kernelmode) ? interval*1000 : 0); e86435eb91b2bf Peter Feuerer 2009-06-21 744 if (IS_ERR(thz_dev)) e86435eb91b2bf Peter Feuerer 2009-06-21 745 return -EINVAL; e86435eb91b2bf Peter Feuerer 2009-06-21 746 48c8dd64345ba2 Peter Feuerer 2014-11-28 @747 if (strcmp(thz_dev->governor->name, 48c8dd64345ba2 Peter Feuerer 2014-11-28 748 acerhdf_zone_params.governor_name)) { 48c8dd64345ba2 Peter Feuerer 2014-11-28 749 pr_err("Didn't get thermal governor %s, perhaps not compiled into thermal subsystem.\n", 48c8dd64345ba2 Peter Feuerer 2014-11-28 750 acerhdf_zone_params.governor_name); 48c8dd64345ba2 Peter Feuerer 2014-11-28 751 return -EINVAL; 48c8dd64345ba2 Peter Feuerer 2014-11-28 752 } 48c8dd64345ba2 Peter Feuerer 2014-11-28 753 e86435eb91b2bf Peter Feuerer 2009-06-21 754 return 0; e86435eb91b2bf Peter Feuerer 2009-06-21 755 } e86435eb91b2bf Peter Feuerer 2009-06-21 756 :::::: The code at line 747 was first introduced by commit :::::: 48c8dd64345ba2a8c41556095c7adacb1c8af7c1 acerhdf: Use bang-bang thermal governor :::::: TO: Peter Feuerer <pe...@piie.net> :::::: CC: Darren Hart <dvh...@linux.intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
