On Mon, Oct 14, 2019 at 03:00:16PM +0200, Andrew Lunn wrote: > On Mon, Oct 14, 2019 at 01:46:26PM +0300, Vladimir Oltean wrote: > > Hi Nishad, > > > > On Sat, 12 Oct 2019 at 15:39, Nishad Kamdar <nishadkam...@gmail.com> wrote: > > > > > > This patch corrects the SPDX License Identifier style > > > in header files related to Distributed Switch Architecture > > > drivers for NXP SJA1105 series Ethernet switch support. > > > For C header files Documentation/process/license-rules.rst > > > mandates C-like comments (opposed to C source files where > > > C++ style should be used) > > > > > > Changes made by using a script provided by Joe Perches here: > > > https://lkml.org/lkml/2019/2/7/46. > > > > > > Suggested-by: Joe Perches <j...@perches.com> > > > Signed-off-by: Nishad Kamdar <nishadkam...@gmail.com> > > > --- > > > > Your commit message has nothing to do with what you're fixing, but > > whatever. The SPDX identifiers _are_ using C-like comments. > > Agreed. Please fix the commit message, and maybe make the script > generating the commit message, so future uses of it will get the > message correct. > > Thanks > Andrew Hello Andrew and Vladimir,
I understand your comments. I will change the commit message in the next version of the patch. Thanks for the review. Regards, Nishad
