On Sat, Sep 29, 2007 at 11:24:26AM +0200, Christoph Hellwig wrote: > On Fri, Sep 28, 2007 at 10:39:48PM +0200, Andreas Gruenbacher wrote: > > On Friday 28 September 2007 20:42, Christoph Hellwig wrote: > > > __d_path should probably switch to taking a struct path * aswell. > > > > Indeed, it now easily can. Here we go... > > > > > > One less parameter to __d_path > > > > All callers to __d_path pass the dentry and vfsmount of a struct > > path to __d_path. Pass the struct path directly, instead. > > Looks good. If you have some sparse time left the dentry and vfsmnt > arguments of __d_path and d_path should probably be switched over > to a struct path aswell. For about half of the callers that works > out easily because they have a struct file, and some need some > reshuffling (e.g. /proc/ symlink code or the dcookies that want to > store a struct path aswell)
And thinking about it the function should also grow a better name, say print_path. And if you really touch it moving the kerneldoc comment to d_path from __d_path would also be very useful. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/