On Fri, 2007-09-28 at 10:28 -0400, Mathieu Desnoyers wrote:
> +struct __mark_marker;
Hi Mathieu,
How about, "struct marker". You've taken the "marker*" namespace, so
all these underscores are __gratuitious__ :)
> +/*
> + * module_mutex nests inside markers_mutex. Markers mutex protects the
> builtin
> + * and module markers, the hash table and deferred_sync.
> + */
> +DEFINE_MUTEX(markers_mutex);
This can be static AFAICT.
The rest looks fine.
Cheers,
Rusty.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
