Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by_name

[Wen Yang]

On 2019/10/2 1:03 上午, David Miller wrote:

From: Wen Yang <weny...@linux.alibaba.com>
Date: Sun, 29 Sep 2019 15:00:47 +0800

of_node_put needs to be called when the device node which is got
from of_get_child_by_name finished using.
irq_domain_add_linear() also calls of_node_get() to increase refcount,
so irq_domain will not be affected when it is released.

fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
Signed-off-by: Wen Yang <weny...@linux.alibaba.com>

Please capitalize Fixes:, seriously I am very curious where did you
learned to specify the fixes tag non-capitalized?

Patch applied, t hanks.

Thank you for your comments.

We checked the code repository and found that both ‘Fixes’ and ‘fixes’
are being used, such as:

commit a53651ec93a8d7ab5b26c5390e0c389048b4b4b6
…
     net: ena: don't wake up tx queue when down
…
     fixes: 1738cd3ed342 (net: ena: Add a driver for Amazon Elastic
Network Adapters (ENA))
…

And,

commit 1df379924304b687263942452836db1d725155df
…
     clk: consoldiate the __clk_get_hw() declarations
…

     Fixes: 59fcdce425b7 ("clk: Remove ifdef for COMMON_CLK in
clk-provider.h")
     fixes: 73e0e496afda ("clkdev: Always allocate a struct clk and call
__clk_get() w/ CCF")
…


It is also found that the sha1 following ‘Fixes:’ requires at least 12
digits.

So we plan to modify the checkpatch.pl script to check for these issues.


diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a85d719..ddcd2d0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2925,7 +2925,7 @@ sub process {
                }

  # check for invalid commit id
-               if ($in_commit_log && $line =~
/(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) {
+               if ($in_commit_log && $line =~ 
/(\bcommit)\s+([0-9a-f]{6,40})\b/i) {
                        my $id;
                        my $description;
                        ($id, $description) = git_commit_info($2, undef, undef);
@@ -2935,6 +2935,25 @@ sub process {
                        }
                }

+# check for fixes tag
+               if ($in_commit_log && $line =~ 
/(^fixes:)\s+([0-9a-f]{6,40})\b/i) {
+                       my $id;
+                       my $description;
+                       ($id, $description) = git_commit_info($2, undef, undef);
+                       if (!defined($id)) {
+                               WARN("UNKNOWN_COMMIT_ID",
+                                    "Unknown commit id '$2', maybe rebased or not 
pulled?\n" .
$herecurr);
+                       }
+                       if ($1 ne "Fixes") {
+                               WARN("FIXES_TAG_STYLE",
+                                    "The fixes tag should be capitalized 
(Fixes:).\n" . $hereprev);
+                       }
+                       if (length($2) < 12) {
+                               WARN("FIXES_TAG_STYLE",
+                                    "SHA1 should be at least 12 digits 
long.\n" . $hereprev);
+                       }
+               }
+
  # ignore non-hunk lines and lines being removed
                next if (!$hunk_line || $line =~ /^-/);

--
Best wishes,
Wen Yang