Move the initialization of ia and ib to the declaration line and remove
a superflous else.

Signed-off-by: Christoph Hellwig <h...@lst.de>
Reviewed-by: Dave Chinner <dchin...@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com>
---
 fs/iomap/buffered-io.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index f8ff96124a86..bb96499c352f 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1226,13 +1226,12 @@ EXPORT_SYMBOL_GPL(iomap_ioend_try_merge);
 static int
 iomap_ioend_compare(void *priv, struct list_head *a, struct list_head *b)
 {
-       struct iomap_ioend *ia, *ib;
+       struct iomap_ioend *ia = container_of(a, struct iomap_ioend, io_list);
+       struct iomap_ioend *ib = container_of(b, struct iomap_ioend, io_list);
 
-       ia = container_of(a, struct iomap_ioend, io_list);
-       ib = container_of(b, struct iomap_ioend, io_list);
        if (ia->io_offset < ib->io_offset)
                return -1;
-       else if (ia->io_offset > ib->io_offset)
+       if (ia->io_offset > ib->io_offset)
                return 1;
        return 0;
 }
-- 
2.20.1

Reply via email to