On Fri, 18 Oct 2019, Luc Van Oostenryck wrote: > On Thu, Oct 17, 2019 at 05:49:26PM -0700, Paul Walmsley wrote: > > sparse identifies these missing prototypes when building arch/riscv: > > > > arch/riscv/kernel/cpu.c:149:29: warning: symbol 'cpuinfo_op' was not > > declared. Should it be static? > > arch/riscv/kernel/irq.c:27:29: warning: symbol 'do_IRQ' was not declared. > > Should it be static? > > arch/riscv/kernel/irq.c:57:13: warning: symbol 'init_IRQ' was not declared. > > Should it be static? > > arch/riscv/kernel/syscall_table.c:15:6: warning: symbol 'sys_call_table' > > was not declared. Should it be static? > > arch/riscv/kernel/time.c:15:13: warning: symbol 'time_init' was not > > declared. Should it be static? > > arch/riscv/kernel/smpboot.c:135:24: warning: symbol 'smp_callin' was not > > declared. Should it be static? > > arch/riscv/kernel/smp.c:72:5: warning: symbol 'setup_profiling_timer' was > > not declared. Should it be static? > > arch/riscv/mm/init.c:151:7: warning: symbol 'trampoline_pg_dir' was not > > declared. Should it be static? > > arch/riscv/mm/init.c:157:7: warning: symbol 'early_pg_dir' was not > > declared. Should it be static? > > arch/riscv/kernel/process.c:32:6: warning: symbol 'show_regs' was not > > declared. Should it be static? > > arch/riscv/kernel/ptrace.c:151:6: warning: symbol 'do_syscall_trace_enter' > > was not declared. Should it be static? > > arch/riscv/kernel/ptrace.c:165:6: warning: symbol 'do_syscall_trace_exit' > > was not declared. Should it be static? > > > > Fix by adding the missing prototypes to the appropriate header files. > > For functions defined in C but used ony in assembly, you can also simply mark > them as '__visible' (aka __attribute__((exrernally_visible)) ).
Thanks, I'll take this suggestion. - Paul
