sparse complains loudly when string literals associated with preprocessor directives are split into multiple, separately quoted strings across different lines:
arch/riscv/mm/init.c:341:9: error: Expected ; at the end of type declaration arch/riscv/mm/init.c:341:9: error: got "not use absolute addressing." arch/riscv/mm/init.c:358:9: error: Trying to use reserved word 'do' as identifier arch/riscv/mm/init.c:358:9: error: Expected ; at end of declaration [ ... ] Existing Linux practice is simply to use a single long line. So, fix by concatenating the strings. This patch should have no functional impact. Signed-off-by: Paul Walmsley <paul.walms...@sifive.com> Reviewed-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Link: https://lore.kernel.org/linux-riscv/caahsdy2nx2lweeazumtw_bygtkho6kauevvxrnba_enejmf...@mail.gmail.com/T/#mc1a58bc864f71278123d19a7abc083a9c8e37033 --- arch/riscv/mm/init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index fa8748a74414..fe68e94ea946 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -339,8 +339,7 @@ static uintptr_t __init best_map_size(phys_addr_t base, phys_addr_t size) */ #ifndef __riscv_cmodel_medany -#error "setup_vm() is called from head.S before relocate so it should " - "not use absolute addressing." +#error "setup_vm() is called from head.S before relocate so it should not use absolute addressing." #endif asmlinkage void __init setup_vm(uintptr_t dtb_pa) -- 2.23.0
