From: Sven Van Asbroeck <[email protected]> [ Upstream commit 7cf58b79b3072029af127ae865ffc6f00f34b1f8 ]
In remove(), ensure that the PME work cannot run after kfree() is called. Otherwise, this could result in a use-after-free. This issue was detected with the help of Coccinelle. Signed-off-by: Sven Van Asbroeck <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Cc: Sinan Kaya <[email protected]> Cc: Frederick Lawler <[email protected]> Cc: Mika Westerberg <[email protected]> Cc: Keith Busch <[email protected]> Cc: Rafael J. Wysocki <[email protected]> Signed-off-by: Sasha Levin <[email protected]> --- drivers/pci/pcie/pme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index e85c5a8206c43..6ac17f0c40775 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie/pme.c @@ -437,6 +437,7 @@ static void pcie_pme_remove(struct pcie_device *srv) pcie_pme_disable_interrupt(srv->port, data); free_irq(srv->irq, srv); + cancel_work_sync(&data->work); kfree(data); } -- 2.20.1
