Dne ponedeljek, 21. oktober 2019 ob 13:13:20 CEST je Hans Verkuil napisal(a): > On 10/17/19 8:37 PM, Jernej Skrabec wrote: > > Allwinner H3 SoC contains deinterlace unit, which has several modes of > > operation - bypass, weave, bob and mixed (advanced) mode. I don't know > > how mixed mode works, but according to Allwinner it gives best results, > > so they use it exclusively. Currently this mode is also hardcoded here. > > > > For each interleaved frame queued, this driver produces 2 deinterlaced > > frames. Deinterlaced frames are based on 2 consequtive output buffers, > > except for the first 2, where same output buffer is given to peripheral > > as current and previous. > > > > There is no documentation for this core, so register layout and fixed > > values were taken from BSP driver. > > > > I'm not sure if maximum size of the image unit is capable to process is > > governed by size of "flag" buffers, frequency or it really is some HW > > limitation. Currently driver can process full HD image in ~15ms (7.5ms > > for each capture buffer), which allows to process 1920x1080@60i video > > smoothly in real time. > > > > Acked-by: Maxime Ripard <mrip...@kernel.org> > > Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net> > > --- > > > > MAINTAINERS | 7 + > > drivers/media/platform/Kconfig | 12 + > > drivers/media/platform/sunxi/Makefile | 1 + > > .../media/platform/sunxi/sun8i-di/Makefile | 2 + > > .../media/platform/sunxi/sun8i-di/sun8i-di.c | 1028 +++++++++++++++++ > > .../media/platform/sunxi/sun8i-di/sun8i-di.h | 237 ++++ > > 6 files changed, 1287 insertions(+) > > create mode 100644 drivers/media/platform/sunxi/sun8i-di/Makefile > > create mode 100644 drivers/media/platform/sunxi/sun8i-di/sun8i-di.c > > create mode 100644 drivers/media/platform/sunxi/sun8i-di/sun8i-di.h > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index c7b48525822a..c375455125fb 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -4646,6 +4646,13 @@ M: "Maciej W. Rozycki" <ma...@linux-mips.org> > > > > S: Maintained > > F: drivers/net/fddi/defxx.* > > > > +DEINTERLACE DRIVERS FOR ALLWINNER H3 > > +M: Jernej Skrabec <jernej.skra...@siol.net> > > +L: linux-me...@vger.kernel.org > > +T: git git://linuxtv.org/media_tree.git > > +S: Maintained > > +F: drivers/media/platform/sunxi/sun8i-di/ > > This is missing the bindings file added in the previous patch.
Well, I listed Maxime and Chen-Yu as binding maintainers in patch 4, so that's why I didn't include it here. If you think I should be maintainer of that binding too, I can change that. I took sun6i-csi as example where binding maintainers are Maxime and Chen-Yu and driver maintainer is Yong Deng. Best regards, Jernej > > Regards, > > Hans > > > + > > > > DELL SMBIOS DRIVER > > M: Pali Rohár <pali.ro...@gmail.com> > > M: Mario Limonciello <mario.limoncie...@dell.com>
