The following commit has been merged into the perf/core branch of tip:

Commit-ID:     3cdc8db91e0e73f94fa6ce3bf966b0152ccf0107
Gitweb:        
https://git.kernel.org/tip/3cdc8db91e0e73f94fa6ce3bf966b0152ccf0107
Author:        Arnaldo Carvalho de Melo <a...@redhat.com>
AuthorDate:    Thu, 17 Oct 2019 16:41:34 -03:00
Committer:     Arnaldo Carvalho de Melo <a...@redhat.com>
CommitterDate: Thu, 17 Oct 2019 17:26:35 -03:00

perf trace: Show error message when not finding a field used in a filter 
expression

It was there, but as pr_debug(), make it pr_err() so that we can see it
without -v:

  # trace -e syscalls:*lseek --filter="whenc==SET" sleep 1
  "whenc" not found in "syscalls:sys_enter_lseek", can't set filter "whenc==SET"
  #

Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Luis Cláudio Gonçalves <lclau...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Link: https://lkml.kernel.org/n/tip-ly4rgm1bto8uwc2itpaix...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/builtin-trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index e71605c..cafd184 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -3611,8 +3611,8 @@ static int trace__expand_filter(struct trace *trace 
__maybe_unused, struct evsel
 
                        fmt = perf_evsel__syscall_arg_fmt(evsel, arg);
                        if (fmt == NULL) {
-                               pr_debug("\"%s\" not found in \"%s\", can't set 
filter \"%s\"\n",
-                                        arg, evsel->name, evsel->filter);
+                               pr_err("\"%s\" not found in \"%s\", can't set 
filter \"%s\"\n",
+                                      arg, evsel->name, evsel->filter);
                                return -1;
                        }
 

Reply via email to