On Mon, Oct 21, 2019 at 03:06:48PM -0500, Navid Emamdoost wrote: > In the impelementation of __ipmi_bmc_register() the allocated memory for > bmc should be released in case ida_simple_get() fails.
Thanks, queued for next merge window. -corey > > Fixes: 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name") > Signed-off-by: Navid Emamdoost <navid.emamdo...@gmail.com> > --- > drivers/char/ipmi/ipmi_msghandler.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c > b/drivers/char/ipmi/ipmi_msghandler.c > index 2aab80e19ae0..e4928ed46396 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -3031,8 +3031,11 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, > bmc->pdev.name = "ipmi_bmc"; > > rv = ida_simple_get(&ipmi_bmc_ida, 0, 0, GFP_KERNEL); > - if (rv < 0) > + if (rv < 0) { > + kfree(bmc); > goto out; > + } > + > bmc->pdev.dev.driver = &ipmidriver.driver; > bmc->pdev.id = rv; > bmc->pdev.dev.release = release_bmc_device; > -- > 2.17.1 >